Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitalize first letter on Signup, Mentor & Mentee Applications #167

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Capitalize first letter on Signup, Mentor & Mentee Applications #167

merged 2 commits into from
Sep 15, 2024

Conversation

Disura-Randunu
Copy link
Contributor

@Disura-Randunu Disura-Randunu commented Sep 15, 2024 •
edited
Loading

Purpose

The purpose of this PR is to fix #160

Goals

Approach

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@Disura-Randunu Disura-Randunu mentioned this pull request Sep 15, 2024
Closed
4 tasks
anjula-sack
anjula-sack requested changes Sep 15, 2024
View reviewed changes
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the lint failures? @Disura-Randunu

@Disura-Randunu
Copy link
Contributor Author

@anjula-sack fixed lint issues

anjula-sack
anjula-sack approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @Disura-Randunu

@anjula-sack anjula-sack merged commit d1d6d7a into sef-global:main Sep 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjula-sack anjula-sack anjula-sack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save profile names capitalized at sign-in, mentee, and mentor applications
2 participants
@Disura-Randunu @anjula-sack